fix: better coverage for distant bins#5521
Open
sbackend123 wants to merge 3 commits into
Open
Conversation
sbackend123
marked this pull request as ready for review
June 29, 2026 13:09
acud
approved these changes
Jul 7, 2026
acud
approved these changes
Jul 16, 2026
Comment on lines
+1045
to
+1050
| if isNeighbor { | ||
| k.metrics.AnnounceIsNeighborTotal.WithLabelValues("true").Inc() | ||
| } else { | ||
| k.metrics.AnnounceIsNeighborTotal.WithLabelValues("false").Inc() | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
maybe simplify code to 1 line by using strconv.FormatBool(isNeighbor)
| Namespace: m.Namespace, | ||
| Subsystem: subsystem, | ||
| Name: "announce_errors_total", | ||
| Help: "Number of announce errors. The reason label is one of: random_subset, broadcast_to_new.", |
Member
There was a problem hiding this comment.
Maybe to add broadcast_to_existing, when calling BroadcastPeers async to existing peers?
gacevicljubisa
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Increased defaultBroadcastBinSize from 2 to 6. During Announce(), this raises the number of peers randomly selected per bin for gossip in both directions: existing peers notified about the newcomer, and existing peers shared with the newcomer.
related to PR #5520
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure